Skip to content

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Mar 7, 2025

No description provided.

elbeno added 2 commits March 7, 2025 17:02
Problem:
- `gen_str_catalog.py` uses `libclang` to parse enumeration data.

Solution:
- Install `libclang`.
Problem:
- Module IDs are generated from a `set` of strings. This means that the ordering
  is not stable.

Solution:
- Sort the set to a list before assigning IDs.
@elbeno elbeno force-pushed the libclang-availability branch from 42f0bc8 to 8a94be2 Compare March 8, 2025 00:03
Problem:
- If `libclang` is not available for `gen_str_catalog.py`, it is possible to
  provide (by fixed manual input) the `enums` part of the JSON output. When
  `libclang` is available, this input would be discarded -- regardless of
  whether it contains enum keys which aren't from parsing.

Solution:
- Merge the dictionaries for the parsed enum values.
@elbeno elbeno merged commit d40c4de into intel:main Mar 10, 2025
24 checks passed
@elbeno elbeno deleted the libclang-availability branch March 12, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants